Bug 225697 – [GStreamer] media/track/in-band/track-in-band-srt-mkv-kind.html is a flaky crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

Results dashboard:

https://results.webkit.org/?suite=layout-tests&test=media%2Ftrack%2Fin-band%2Ftrack-in-band-srt-mkv-kind.html&platform=GTK&platform=WPE

Stacktrace:

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277365%20(1704)/media/track/in-band/track-in-band-srt-mkv-kind-crash-log.txt

Using host libthread_db library "/usr/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/app/webkit/WebKitBuild/Release/bin/WebKitWebProcess 279 13 --configure-jsc-for'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007fde48001069 in WebCore::MediaPlayerPrivateGStreamer::handleTextSample(_GstSample*, char const*) () from /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0
[Current thread is 1 (Thread 0x7fde3d9d2e80 (LWP 120958))]

Thread 1 (Thread 0x7fde3d9d2e80 (LWP 120958)):
#0  0x00007fde48001069 in WebCore::MediaPlayerPrivateGStreamer::handleTextSample(_GstSample*, char const*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0
#1  0x00007fde438000bb in WTF::RunLoop::performWork() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0
#2  0x00007fde4386e8f9 in WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0
#3  0x00007fde4386f3df in WTF::RunLoop::{lambda(_GSource*, int (*)(void*), void*)#1}::_FUN(_GSource*, int (*)(void*), void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0
#4  0x00007fde400b6dbf in g_main_dispatch (context=0x560e3f468930) at ../glib/gmain.c:3337
#5  g_main_context_dispatch (context=0x560e3f468930) at ../glib/gmain.c:4055
#6  0x00007fde400b7168 in g_main_context_iterate (context=0x560e3f468930, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4131
#7  0x00007fde400b7483 in g_main_loop_run (loop=0x560e3f497740) at ../glib/gmain.c:4329
#8  0x00007fde4386f528 in WTF::RunLoop::run() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.1.so.0
#9  0x00007fde45d60b5f in int WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainGtk>(int, char**) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0
#10 0x00007fde3fa59062 in __libc_start_main (main=0x560e3f23f850 <main>, argc=4, argv=0x7ffe284dccf8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffe284dcce8) at ../csu/libc-start.c:308
#11 0x0000560e3f23f88e in _start () at ../sysdeps/x86_64/start.S:120

There was recent change in the line where the test is crashing (https://webkit-search.igalia.com/webkit/source/Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp#67), but I think it's unrelated since the test has been crashing sporadically before that.

The test doesn't seem to crash in Debug.

[Enrique Ocaña]

Created attachment 428511 [details]
Patch

[Alicia Boya García]

Comment on attachment 428511 [details]
Patch

LGTM. It's important to be careful with callbacks indeed.

[EWS]

Committed r277432 (237680@main): <https://commits.webkit.org/237680@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428511 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77964181>