Bug 225653 - Import new and updated css-scroll-snap WPT tests
Summary: Import new and updated css-scroll-snap WPT tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-11 07:40 PDT by Martin Robinson
Modified: 2021-05-13 04:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (112.69 KB, patch)
2021-05-11 07:44 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (114.99 KB, patch)
2021-05-11 08:25 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (116.58 KB, patch)
2021-05-12 00:38 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (116.43 KB, patch)
2021-05-12 00:57 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (116.44 KB, patch)
2021-05-13 03:32 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-05-11 07:40:39 PDT 
SSIA
Comment 1 Martin Robinson 2021-05-11 07:44:23 PDT 
Created attachment 428274 [details]
Patch
Comment 2 Martin Robinson 2021-05-11 08:25:23 PDT 
Created attachment 428278 [details]
Patch
Comment 3 Martin Robinson 2021-05-12 00:38:44 PDT 
Created attachment 428350 [details]
Patch
Comment 4 Martin Robinson 2021-05-12 00:57:49 PDT 
Created attachment 428353 [details]
Patch
Comment 5 Sergio Villar Senin 2021-05-13 03:27:14 PDT 
Comment on attachment 428353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428353&action=review

> LayoutTests/ChangeLog:8
> +        * platform/ios-wk2/TestExpectations: Skip failing imported tests.

Missing entry for LayoutTests/TestExpectations ?
Comment 6 Martin Robinson 2021-05-13 03:32:11 PDT 
Created attachment 428485 [details]
Patch
Comment 7 Martin Robinson 2021-05-13 03:33:00 PDT 
Comment on attachment 428485 [details]
Patch

Thanks for the review. I have corrected the ChangeLog.
Comment 8 EWS 2021-05-13 04:10:15 PDT 
Committed r277430 (237678@main): <https://commits.webkit.org/237678@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428485 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-13 04:11:16 PDT 
<rdar://problem/77960558>