Bug 225649 - REGRESSION(r277083): Proximity scroll snap is broken on iOS
Summary: REGRESSION(r277083): Proximity scroll snap is broken on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-11 04:28 PDT by Martin Robinson
Modified: 2021-05-12 01:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2021-05-11 06:13 PDT, Martin Robinson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.90 KB, patch)
2021-05-11 06:37 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-05-11 04:28:15 PDT 
Instead of respecting the proximity setting, scroll snap always uses the mandatory setting.
Comment 1 Martin Robinson 2021-05-11 06:13:53 PDT 
Created attachment 428267 [details]
Patch
Comment 2 Martin Robinson 2021-05-11 06:37:12 PDT 
Created attachment 428270 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-05-11 10:40:44 PDT 
Comment on attachment 428270 [details]
Patch

Please check the failing tests.
Comment 4 Martin Robinson 2021-05-12 01:00:17 PDT 
Comment on attachment 428270 [details]
Patch

Thanks for the review! It looks like all the EWS bubbles are green so I'm going to land this one.
Comment 5 EWS 2021-05-12 01:09:15 PDT 
Committed r277362 (237620@main): <https://commits.webkit.org/237620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428270 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-12 01:10:16 PDT 
<rdar://problem/77889995>