Bug 225602 - Remove xpc_connection_kill
Summary: Remove xpc_connection_kill
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-10 11:29 PDT by Alex Christensen
Modified: 2021-05-27 13:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.99 KB, patch)
2021-05-10 11:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2021-05-11 13:10 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2021-05-11 14:23 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-10 11:29:36 PDT
Remove xpc_connection_kill
Comment 1 Alex Christensen 2021-05-10 11:30:27 PDT
Created attachment 428186 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-05-10 14:38:30 PDT
Comment on attachment 428186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428186&action=review

> Source/WebKit/ChangeLog:8
> +        We were waiting on two other parts of the OS to update, and they have now.

How did you confirm that this doesn't break WebKit on iOS 14.5? Looking at these radars, I'm concerned that we may start having crash-looping daemons there, which is a problem for perf testing in particular.

Maybe put this behind a version check to be safe?
Comment 3 Alex Christensen 2021-05-10 18:22:36 PDT
I can't conclusively say that we didn't break WebKit on iOS 14.5, but given that we submitted the change and these are the only two problems we found sounds promising.  I think we should make this change again before more system pieces start assuming this change has not been made.
Comment 4 Alex Christensen 2021-05-10 18:40:35 PDT
And like we did the first time, if we find anything indicating that we should revert this, I'm not opposed to reverting it again.  All known problems have been fixed and we have reason to believe that we found most if not all of the problems.
Comment 5 Alexey Proskuryakov 2021-05-11 12:05:25 PDT
I don't object to making the change for future versions, but I still suggest not changing the behavior on iOS 14 to be safe.
Comment 6 Alex Christensen 2021-05-11 13:10:33 PDT
Created attachment 428308 [details]
Patch
Comment 7 Alex Christensen 2021-05-11 14:23:11 PDT
Created attachment 428311 [details]
Patch
Comment 8 EWS 2021-05-11 17:05:57 PDT
Committed r277344 (237602@main): <https://commits.webkit.org/237602@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428311 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-11 17:06:20 PDT
<rdar://problem/77870298>
Comment 10 Alex Christensen 2021-05-27 13:48:30 PDT
Reverted in r278176