Bug 225445 - Re-import css/css-contain WPT
Summary: Re-import css/css-contain WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: update-css-wpt
  Show dependency treegraph
 
Reported: 2021-05-06 03:25 PDT by Tim Nguyen (:ntim)
Modified: 2021-05-06 05:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (24.73 KB, patch)
2021-05-06 03:38 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff
Patch (25.49 KB, patch)
2021-05-06 04:15 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-05-06 03:25:45 PDT
some wpt to reimport
Comment 1 Tim Nguyen (:ntim) 2021-05-06 03:38:11 PDT
Created attachment 427865 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2021-05-06 04:15:57 PDT
Created attachment 427867 [details]
Patch
Comment 3 Rob Buis 2021-05-06 05:30:24 PDT
Comment on attachment 427867 [details]
Patch

LGTM. BTW we usually state the git hash where the import is based on in the Changelog.
Comment 4 Tim Nguyen (:ntim) 2021-05-06 05:41:59 PDT
Thanks! I don't have the exact hash, but I'll keep that in mind next time.

My guess would be around this one: https://github.com/web-platform-tests/wpt/commit/ee1e6f06ad467fa666ff76af9f45a1dbe73f3ebb#diff-36e64f19f57a05c8cd5b6bf7eff72703b4bbab19def7832eb4e686e7fa482eef
Comment 5 EWS 2021-05-06 05:58:43 PDT
Committed r277084 (237387@main): <https://commits.webkit.org/237387@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427867 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-06 05:59:12 PDT
<rdar://problem/77603833>