Bug 224895 - Crash under RegistrationDatabase::openSQLiteDatabase()
Summary: Crash under RegistrationDatabase::openSQLiteDatabase()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 14:15 PDT by Chris Dumez
Modified: 2021-04-21 17:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2021-04-21 14:22 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-04-21 14:15:06 PDT 
Crash under RegistrationDatabase::openSQLiteDatabase():
Thread 17 name:  Dispatch queue: ServiceWorker I/O Thread
Thread 17 Crashed ↩:
0   JavaScriptCore                	0x00000001aaada524 WTF::StringImpl::stripWhiteSpace() + 92 (StringImpl.cpp:736)
1   JavaScriptCore                	0x00000001aab2fdf4 WTF::String::stripWhiteSpace() const + 40 (WTFString.cpp:377)
2   JavaScriptCore                	0x00000001aab2fdf4 WTF::String::stripWhiteSpace() const + 40 (WTFString.cpp:377)
3   WebCore                       	0x00000001aedb8830 WebCore::SQLiteStatement::prepare() + 64 (SQLiteStatement.cpp:62)
4   WebCore                       	0x00000001aedb8a70 WebCore::SQLiteStatement::executeCommand() + 116 (SQLiteStatement.cpp:132)
5   WebCore                       	0x00000001af37cbd8 WebCore::RegistrationDatabase::openSQLiteDatabase(WTF::String const&) + 1292 (SQLiteDatabase.cpp:376)
6   WebCore                       	0x00000001af3946c4 WTF::Detail::CallableWrapper<WebCore::RegistrationDatabase::schedulePushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&, WTF::Vector<WebCore::ServiceWorkerRegistrationKey, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&, WTF::CompletionHandler<void ()>&&)::$_26, void>::call() + 120 (RegistrationDatabase.cpp:346)
7   libdispatch.dylib             	0x00000001a03cea54 _dispatch_call_block_and_release + 32 (init.c:1466)
8   libdispatch.dylib             	0x00000001a03d07ec _dispatch_client_callout + 20 (object.m:559)
9   libdispatch.dylib             	0x00000001a03d7fd4 _dispatch_lane_serial_drain + 620 (inline_internal.h:2557)
10  libdispatch.dylib             	0x00000001a03d8bd0 _dispatch_lane_invoke + 404 (queue.c:3862)
11  libdispatch.dylib             	0x00000001a03e348c _dispatch_workloop_worker_thread + 764 (queue.c:6589)
12  libsystem_pthread.dylib       	0x00000001eb54a7a4 _pthread_wqthread + 276 (pthread.c:2231)
13  libsystem_pthread.dylib       	0x00000001eb55174c start_wqthread + 8
Comment 1 Chris Dumez 2021-04-21 14:15:19 PDT 
<rdar://64574013>
Comment 2 Chris Dumez 2021-04-21 14:22:49 PDT 
Created attachment 426746 [details]
Patch
Comment 3 Geoffrey Garen 2021-04-21 14:27:07 PDT 
Comment on attachment 426746 [details]
Patch

r=me
Comment 4 EWS 2021-04-21 17:50:18 PDT 
Committed r276409 (236874@main): <https://commits.webkit.org/236874@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426746 [details].