Bug 224886 – Get webkitpy.common.checkout.scm.scm_unittest passing

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sam Sneddon [:gsnedders]]

Our tests should pass.

This is potentially the first step before enabling them on EWS, even if we keep them disabled (for being slow) by default.

[Sam Sneddon [:gsnedders]]

Created attachment 426727 [details]
Patch

[Jonathan Bedard]

Comment on attachment 426727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426727&action=review

> Tools/Scripts/webkitpy/test/markers.py:26
> +def xfail(*args, **kwargs):

What other decorators do we intend to add to this file? I like this API, and like the fact that we are matching pytest.xfail (potentially replacing this in the future?) I wonder if this should live in webkitcorepy, though, so we could use this in testing that doesn't depend on webkitpy.

[Sam Sneddon [:gsnedders]]

(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 426727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426727&action=review
> 
> > Tools/Scripts/webkitpy/test/markers.py:26
> > +def xfail(*args, **kwargs):
> 
> What other decorators do we intend to add to this file? I like this API, and
> like the fact that we are matching pytest.xfail (potentially replacing this
> in the future?) I wonder if this should live in webkitcorepy, though, so we
> could use this in testing that doesn't depend on webkitpy.

I could foresee us re-introducing various skip markers (especially for tests where we simply disable entire modules currently on certain OSes).

And yes, that we match pytest.mark.xfail is completely deliberate to allow for future migration through simply removing our wrapper.

I put this in webkitpy mostly because that's where the old skip_if decorator was; no other reason for it to be there! Happy to move it webkitcorepy if you want?

[Jonathan Bedard]

(In reply to Sam Sneddon [:gsnedders] from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > Comment on attachment 426727 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=426727&action=review
> > 
> > > Tools/Scripts/webkitpy/test/markers.py:26
> > > +def xfail(*args, **kwargs):
> > 
> > What other decorators do we intend to add to this file? I like this API, and
> > like the fact that we are matching pytest.xfail (potentially replacing this
> > in the future?) I wonder if this should live in webkitcorepy, though, so we
> > could use this in testing that doesn't depend on webkitpy.
> 
> I could foresee us re-introducing various skip markers (especially for tests
> where we simply disable entire modules currently on certain OSes).
> 
> And yes, that we match pytest.mark.xfail is completely deliberate to allow
> for future migration through simply removing our wrapper.
> 
> I put this in webkitpy mostly because that's where the old skip_if decorator
> was; no other reason for it to be there! Happy to move it webkitcorepy if
> you want?

Let's land this as is now, and discuss moving later. I think we do want something like this in webkitcorepy ultimately. I've explored this idea before, in particular, resultsdbpy has some interesting testing decorators that do things like run the same test with in-memory database mocks and actual databases.

[EWS]

Committed r276436 (236899@main): <https://commits.webkit.org/236899@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426727 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77032460>