Bug 224879 - webkitpy's git code should always use --no-abbrev-commit
Summary: webkitpy's git code should always use --no-abbrev-commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 10:41 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-22 18:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2021-04-21 10:49 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-21 10:41:58 PDT 
At least some of our tests break with log.abbrevCommit set to true. I don't know how much this breaks actual functionality, but we should simply outright avoid it being a risk by always passing --no-abbrev-commit to log/show which overrides the config option.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-21 10:49:29 PDT 
Created attachment 426713 [details]
Patch
Comment 2 EWS 2021-04-21 13:06:51 PDT 
Committed r276387 (236862@main): <https://commits.webkit.org/236862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426713 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-22 18:08:12 PDT 
<rdar://problem/77048736>