Bug 224870 - Import css/css-will-change tests from WPT
Summary: Import css/css-will-change tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-21 08:01 PDT by Tim Nguyen (:ntim)
Modified: 2021-04-21 22:12 PDT (History)
6 users (show)

See Also:

Attachments
Patch (50.72 KB, patch)
2021-04-21 08:24 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (54.73 KB, patch)
2021-04-21 13:28 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (63.09 KB, patch)
2021-04-21 15:53 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (63.09 KB, patch)
2021-04-21 16:48 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-04-21 08:01:21 PDT 
https://github.com/web-platform-tests/wpt/tree/master/css/css-will-change

Contains many useful tests that would increase the coverage of CSS will-change.
Comment 1 Radar WebKit Bug Importer 2021-04-21 08:01:34 PDT 
<rdar://problem/76959270>
Comment 2 Tim Nguyen (:ntim) 2021-04-21 08:24:12 PDT 
Created attachment 426691 [details]
Patch
Comment 3 youenn fablet 2021-04-21 08:40:32 PDT 
Comment on attachment 426691 [details]
Patch

r=me once bots are happy.

View in context: https://bugs.webkit.org/attachment.cgi?id=426691&action=review

> LayoutTests/imported/w3c/css/css-will-change/parsing/w3c-import.log:17
> +/LayoutTests/imported/w3c/css/css-will-change/parsing/will-change-computed.html

Path is not good here.
Should be /LayoutTests/imported/w3c/web-platform-tests/css/...
Comment 4 Tim Nguyen (:ntim) 2021-04-21 13:28:29 PDT 
Created attachment 426737 [details]
Patch
Comment 5 Tim Nguyen (:ntim) 2021-04-21 15:53:20 PDT 
Created attachment 426750 [details]
Patch
Comment 6 Tim Nguyen (:ntim) 2021-04-21 16:48:13 PDT 
Created attachment 426754 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2021-04-21 16:49:27 PDT 
Comment on attachment 426754 [details]
Patch

There was just one missing blank line in one of the -expected.txt file in the previous patch :(
Comment 8 EWS 2021-04-21 22:12:16 PDT 
Committed r276422 (236887@main): <https://commits.webkit.org/236887@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426754 [details].