ANGLE should be compiled with thread-safe statics The code assumes that, as that's the c++ semantics and ANGLE is a c++ project.
Created attachment 426651 [details] Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 426651 [details] Patch Seems fine. r+
Comment on attachment 426651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426651&action=review > Source/ThirdParty/ANGLE/ChangeLog:11 > + Compile ANGLE with normal thread-safe c++ local statics. > + No known threading failures. Based on ad-hoc risk vs benefit > + evaluation of today and after future merges, it appears > + better to err in the side of caution. Excellent that we can/will do this. This comment addresses the safety side of the tradeoff. What about the performance side?
<rdar://problem/77250303>
(In reply to Darin Adler from comment #4) > Excellent that we can/will do this. > > This comment addresses the safety side of the tradeoff. What about the > performance side? Based on ad hoc testing of WebGL, I could not spot any difference.
Committed r276693 (237107@main): <https://commits.webkit.org/237107@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426651 [details].