Bug 224721 - [Curl] Remove warnings on curl layer.
Summary: [Curl] Remove warnings on curl layer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-17 12:47 PDT by Basuke Suzuki
Modified: 2021-04-24 15:07 PDT (History)
8 users (show)

See Also:


Attachments
PATCH (5.86 KB, patch)
2021-04-17 13:41 PDT, Basuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-04-17 12:47:30 PDT
There's several warnings:

[2033/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CurlFormDataStream.cpp.o
../../Source/WebCore/platform/network/curl/CurlFormDataStream.cpp:131:60: warning: unused parameter 'blobData' [-Wunused-parameter]
            }, [] (const FormDataElement::EncodedBlobData& blobData) {
                                                           ^
1 warning generated.
[2043/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CookieJarDB.cpp.o
../../Source/WebCore/platform/network/curl/CookieJarDB.cpp:641:9: warning: unused variable 'ret' [-Wunused-variable]
    int ret = statement->prepare();
        ^
1 warning generated.
[2044/5049] Building CXX object Source/WebCore/CMakeFiles/....dir/platform/network/curl/NetworkStorageSessionCurl.cpp.o
../../Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:98:133: warning: unused parameter 'frameID' [-Wunused-parameter]
void NetworkStorageSession::setCookiesFromDOM(const URL& firstParty, const SameSiteInfo&, const URL& url, Optional<FrameIdentifier> frameID, Optional<PageIdentifier> pageID, ShouldAskITP, const String& value, ShouldRelaxThirdPartyCookieBlocking shouldRelaxThirdPartyCookieBlocking) const

            ^
../../Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:98:246: warning: unused parameter 'shouldRelaxThirdPartyCookieBlocking' [-Wunused-parameter]
void NetworkStorageSession::setCookiesFromDOM(const URL& firstParty, const SameSiteInfo&, const URL& url, Optional<FrameIdentifier> frameID, Optional<PageIdentifier> pageID, ShouldAskITP, const String& value, ShouldRelaxThirdPartyCookieBlocking shouldRelaxThirdPartyCookieBlocking) const


     ^
2 warnings generated.
[2048/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CurlRequest.cpp.o
../../Source/WebCore/platform/network/curl/CurlRequest.cpp:532:45: warning: unused parameter 'request' [-Wunused-parameter]
void CurlRequest::setupPUT(ResourceRequest& request)
                                            ^
../../Source/WebCore/platform/network/curl/CurlRequest.cpp:546:46: warning: unused parameter 'request' [-Wunused-parameter]
void CurlRequest::setupPOST(ResourceRequest& request)
                                             ^
2 warnings generated.
Comment 1 Basuke Suzuki 2021-04-17 13:41:31 PDT
Created attachment 426346 [details]
PATCH
Comment 2 EWS 2021-04-17 15:55:21 PDT
Committed r276211 (236693@main): <https://commits.webkit.org/236693@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426346 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-24 15:07:03 PDT
<rdar://problem/77110088>