Bug 224442 - Test objects should know if they need servers
Summary: Test objects should know if they need servers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks: 220421
  Show dependency tree / graph
 
Reported: 2021-04-12 10:45 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-13 09:54 PDT (History)
4 users (show)

See Also:

Attachments
Patch (11.87 KB, patch)
2021-04-12 10:57 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-12 10:45:57 PDT 
Manager._is_http_test, Manager._needs_web_platform_test, Manager._is_websocket_test etc. should all be known by Test, and computed by the LayoutTestFinder. Alternate explanation: Manager shouldn't know about specific paths.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-12 10:57:22 PDT 
Created attachment 425766 [details]
Patch
Comment 2 EWS 2021-04-13 09:48:02 PDT 
Committed r275888 (236453@main): <https://commits.webkit.org/236453@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425766 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-13 09:54:23 PDT 
<rdar://problem/76596286>