Bug 224440 - Move RuntimeEnabledFeatures to Settings (Part 1)
Summary: Move RuntimeEnabledFeatures to Settings (Part 1)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-12 09:17 PDT by Sam Weinig
Modified: 2021-04-24 15:07 PDT (History)
23 users (show)

See Also:

Attachments
Patch (111.34 KB, patch)
2021-04-12 10:05 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (111.26 KB, patch)
2021-04-12 10:25 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (111.26 KB, patch)
2021-04-12 10:52 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (114.54 KB, patch)
2021-04-12 13:38 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (114.78 KB, patch)
2021-04-12 15:07 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (115.08 KB, patch)
2021-04-12 15:27 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (111.69 KB, patch)
2021-04-13 09:52 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (110.97 KB, patch)
2021-04-14 09:01 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (111.01 KB, patch)
2021-04-16 09:30 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (111.49 KB, patch)
2021-04-16 18:29 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-04-12 09:17:57 PDT 
Move RuntimeEnabledFeatures to Settings (Part 1)
Comment 1 Sam Weinig 2021-04-12 10:05:20 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-04-12 10:25:44 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-04-12 10:52:48 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2021-04-12 13:38:41 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-04-12 15:07:02 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2021-04-12 15:27:15 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2021-04-13 06:58:30 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2021-04-13 09:52:31 PDT Comment hidden (obsolete)
Comment 9 Sam Weinig 2021-04-14 09:01:02 PDT 
Created attachment 425992 [details]
Patch
Comment 10 Alex Christensen 2021-04-15 17:41:05 PDT 
Comment on attachment 425992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425992&action=review

> Source/WTF/Scripts/Preferences/WebPreferences.yaml:1679
> +      default: true

It feels like this might also need to be WebCore::LibWebRTCProvider::webRTCAvailable but I'm not sure.  Getting this wrong might affect the base system.
Comment 11 Sam Weinig 2021-04-16 08:52:17 PDT 
In practice those values only effect svg image documents where I don’t think script can’t run, so I don’t think it matters in this case, but since I can use that I will make the change.
Comment 12 Sam Weinig 2021-04-16 09:30:17 PDT 
Created attachment 426236 [details]
Patch
Comment 13 EWS 2021-04-16 10:15:33 PDT 
Patch 426236 does not build
Comment 14 Sam Weinig 2021-04-16 18:29:42 PDT 
Created attachment 426306 [details]
Patch
Comment 15 EWS 2021-04-16 19:26:02 PDT 
Patch 426306 does not build
Comment 16 Sam Weinig 2021-04-17 09:17:39 PDT 
(In reply to Sam Weinig from comment #11)
> In practice those values only effect svg image documents where I don’t think
> script can’t run, so I don’t think it matters in this case, but since I can
> use that I will make the change.

Lol, not so easy to make this change. Touché WebCore.
Comment 17 EWS 2021-04-17 13:07:39 PDT 
Committed r276204 (236686@main): <https://commits.webkit.org/236686@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425992 [details].
Comment 18 Radar WebKit Bug Importer 2021-04-24 15:07:34 PDT 
<rdar://problem/77110098>