Bug 223471 - Avoid copying item data when iterating in-process display lists
Summary: Avoid copying item data when iterating in-process display lists
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-18 12:46 PDT by Wenson Hsieh
Modified: 2021-03-18 16:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.70 KB, patch)
2021-03-18 13:03 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-03-18 12:46:11 PDT
This copy is unnecessary (and potentially expensive) in the case of in-process display lists (e.g. the display lists used to cache glyph data when painting text at high frequency).

Impacts the Design subtest of MotionMark.
Comment 1 Wenson Hsieh 2021-03-18 13:03:56 PDT
Created attachment 423639 [details]
Patch
Comment 2 Wenson Hsieh 2021-03-18 13:35:21 PDT
(After a few quick tests, this seems to give us around +5% on Design)
Comment 3 EWS 2021-03-18 16:43:00 PDT
Committed r274688: <https://commits.webkit.org/r274688>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423639 [details].
Comment 4 Radar WebKit Bug Importer 2021-03-18 16:43:16 PDT
<rdar://problem/75597154>