Bug 223399 - Make fast/images/missing-content-image-crash.html results consistent with internal build
Summary: Make fast/images/missing-content-image-crash.html results consistent with int...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-17 14:03 PDT by Alex Christensen
Modified: 2021-03-17 22:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.01 KB, patch)
2021-03-17 14:04 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (6.20 KB, patch)
2021-03-17 16:52 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.55 KB, patch)
2021-03-17 20:08 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-03-17 14:03:07 PDT 
Make fast/images/missing-content-image-crash.html results consistent with internal build
Comment 1 Alex Christensen 2021-03-17 14:04:08 PDT 
Created attachment 423528 [details]
Patch
Comment 2 Alex Christensen 2021-03-17 14:04:11 PDT 
<rdar://problem/75443811>
Comment 3 Alex Christensen 2021-03-17 16:52:39 PDT 
Created attachment 423541 [details]
Patch
Comment 4 Alex Christensen 2021-03-17 20:08:35 PDT 
Created attachment 423554 [details]
Patch
Comment 5 Darin Adler 2021-03-17 21:37:56 PDT 
Comment on attachment 423554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423554&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:206
> +                        "'http://www.webkit.org/path3',"

So are we relying on *not* putting www.webkit.org on the list? Seems a little sketchy.
Comment 6 Alex Christensen 2021-03-17 22:05:24 PDT 
Comment on attachment 423554 [details]
Patch

True, but we are relying on a lot of domains in the list in our tests.  When/if we add them, we will have similar failing tests internally and we'll do this again.
Comment 7 EWS 2021-03-17 22:30:59 PDT 
Committed r274615: <https://commits.webkit.org/r274615>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423554 [details].