Bug 223390 - don't use raw unicode characters in modern media controls JS
Summary: don't use raw unicode characters in modern media controls JS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-17 11:40 PDT by Devin Rousso
Modified: 2021-03-17 12:26 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.15 KB, patch)
2021-03-17 11:41 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-17 11:40:26 PDT 
this causes JSC to evaluate the script as UTF-16
Comment 1 Devin Rousso 2021-03-17 11:41:31 PDT 
Created attachment 423511 [details]
Patch
Comment 2 EWS 2021-03-17 12:22:26 PDT 
Committed r274578: <https://commits.webkit.org/r274578>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423511 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-17 12:23:13 PDT 
<rdar://problem/75538232>
Comment 4 Simon Fraser (smfr) 2021-03-17 12:26:37 PDT 
Comment on attachment 423511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423511&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Modules/modern-media-controls/controls/icon-service.js:

Missing the "why".