Bug 223267 - Web Automation: Web Share menu being open causes hang in `Automation.isShowingJavaScriptDialog`
Summary: Web Automation: Web Share menu being open causes hang in `Automation.isShowin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-16 11:46 PDT by Patrick Angle
Modified: 2021-03-16 13:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1.0 (1.67 KB, patch)
2021-03-16 12:06 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-03-16 11:46:22 PDT 
.
Comment 1 Patrick Angle 2021-03-16 11:46:49 PDT 
<rdar://74197601>
Comment 2 Patrick Angle 2021-03-16 12:06:07 PDT 
Created attachment 423376 [details]
Patch v1.0
Comment 3 BJ Burg 2021-03-16 12:08:13 PDT 
Comment on attachment 423376 [details]
Patch v1.0

r=me
Comment 4 BJ Burg 2021-03-16 12:55:51 PDT 
commit-queue is hitting some tests that flakily time out, but I don't think it's related to this change.
Comment 5 EWS 2021-03-16 13:05:22 PDT 
Committed r274509: <https://commits.webkit.org/r274509>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423376 [details].
Comment 6 Patrick Angle 2021-03-16 13:06:15 PDT 
(In reply to BJ Burg from comment #4)
> commit-queue is hitting some tests that flakily time out, but I don't think
> it's related to this change.

I agree they appear unrelated, plus I can't see a way that any of these tests could fail based on what this change actually is.

The one test that crashed appears to have a history of doing so as well.