Bug 223239 - [macOS] change for the language/subtitle tracks button to use an `NSMenu` instead of web content
Summary: [macOS] change for the language/subtitle tracks button to use an `NSMenu` ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 21:39 PDT by Devin Rousso
Modified: 2021-03-23 21:26 PDT (History)
17 users (show)

See Also:

Attachments
Patch (290.06 KB, patch)
2021-03-15 22:02 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (308.68 KB, patch)
2021-03-16 11:26 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (307.01 KB, patch)
2021-03-16 12:49 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (310.00 KB, patch)
2021-03-16 13:53 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-15 21:39:04 PDT 
similar to <https://webkit.org/b/221594> ([iOS] Add support for the language/subtitle tracks button using `UIMenu`)
Comment 1 Radar WebKit Bug Importer 2021-03-15 21:39:25 PDT 
<rdar://problem/75462340>
Comment 2 Devin Rousso 2021-03-15 22:02:06 PDT 
Created attachment 423297 [details]
Patch
Comment 3 Eric Carlson 2021-03-16 08:34:34 PDT 
Comment on attachment 423297 [details]
Patch

rs=me once the bots are happy
Comment 4 Devin Rousso 2021-03-16 11:26:43 PDT 
Created attachment 423367 [details]
Patch
Comment 5 Devin Rousso 2021-03-16 12:49:55 PDT 
Created attachment 423383 [details]
Patch
Comment 6 Devin Rousso 2021-03-16 13:53:54 PDT 
Created attachment 423395 [details]
Patch
Comment 7 EWS 2021-03-16 14:57:23 PDT 
Committed r274521: <https://commits.webkit.org/r274521>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423395 [details].