Bug 223220 - [Multi-column] Ignore line grid offset when the grid line is shorter than 0.5px
Summary: [Multi-column] Ignore line grid offset when the grid line is shorter than 0.5px
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 15:31 PDT by zalan
Modified: 2021-03-15 17:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.46 KB, patch)
2021-03-15 16:05 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2021-03-15 16:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-03-15 15:31:29 PDT 
<rdar://73192773>
Comment 1 zalan 2021-03-15 16:05:44 PDT 
Created attachment 423258 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-03-15 16:11:40 PDT 
Comment on attachment 423258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423258&action=review

> Source/WebCore/rendering/RenderLayoutState.cpp:205
> +    if (!roundToInt(lineGridBox->lineBoxHeight()))

Maybe store lineBoxHeight in a local variable since this code now calls it three times.
Comment 3 zalan 2021-03-15 16:16:56 PDT 
Created attachment 423259 [details]
Patch
Comment 4 EWS 2021-03-15 17:52:11 PDT 
Committed r274456: <https://commits.webkit.org/r274456>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423259 [details].