Bug 223218 - [WK2] Can get stuck in fullscreen mode if node is removed prior to receiving willEnterFullscreen()
Summary: [WK2] Can get stuck in fullscreen mode if node is removed prior to receiving ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 15:14 PDT by Jer Noble
Modified: 2021-03-15 20:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.06 KB, patch)
2021-03-15 15:19 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (16.96 KB, patch)
2021-03-15 17:34 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (16.96 KB, patch)
2021-03-15 17:36 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-03-15 15:14:49 PDT 
[WK2] Can get stuck in fullscreen mode if node is removed prior to receiving willEnterFullscreen()
Comment 1 Jer Noble 2021-03-15 15:15:47 PDT 
<rdar://75009548>
Comment 2 Jer Noble 2021-03-15 15:19:51 PDT 
Created attachment 423252 [details]
Patch
Comment 3 Eric Carlson 2021-03-15 16:06:39 PDT 
Comment on attachment 423252 [details]
Patch

r=me once the bots are happy
Comment 4 Peng Liu 2021-03-15 16:18:08 PDT 
Comment on attachment 423252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423252&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenRemoveNodeBeforeEnter.mm:30
> +// Enable theis test on iOS once that issue is resolved.

Nit. s/theis/this/g
Comment 5 Jer Noble 2021-03-15 17:34:34 PDT 
Created attachment 423271 [details]
Patch for landing
Comment 6 Jer Noble 2021-03-15 17:36:01 PDT 
Created attachment 423272 [details]
Patch for landing
Comment 7 EWS 2021-03-15 20:03:29 PDT 
Committed r274460: <https://commits.webkit.org/r274460>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423272 [details].