Bug 223207 - [iOS] WebPageProxy's EditorState may be stale until the next remote layer tree commit
Summary: [iOS] WebPageProxy's EditorState may be stale until the next remote layer tre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 12:26 PDT by Wenson Hsieh
Modified: 2021-03-15 20:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (20.75 KB, patch)
2021-03-15 13:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (20.78 KB, patch)
2021-03-15 14:24 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-03-15 12:26:42 PDT 
<rdar://problem/75410700>
Comment 1 Wenson Hsieh 2021-03-15 13:19:09 PDT 
Created attachment 423228 [details]
Patch
Comment 2 Tim Horton 2021-03-15 13:28:17 PDT 
Comment on attachment 423228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423228&action=review

> Source/WebKit/ChangeLog:3
> +        Refactor some codepaths for updating EditorState in the UI process

Is it possible for this to state the problem instead of the solution?

> Source/WebKit/ChangeLog:20
> +        3.  The pending `BackingStoreFlusher` created in step (1) dispatches on the background queue, and sends its
> +            editor state over to the UI process.

Oh no
Comment 3 Wenson Hsieh 2021-03-15 13:35:28 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 423228 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423228&action=review
> 
> > Source/WebKit/ChangeLog:3
> > +        Refactor some codepaths for updating EditorState in the UI process
> 
> Is it possible for this to state the problem instead of the solution?

Good point! Retitling the bug...

> 
> > Source/WebKit/ChangeLog:20
> > +        3.  The pending `BackingStoreFlusher` created in step (1) dispatches on the background queue, and sends its
> > +            editor state over to the UI process.
> 
> Oh no

Quite 😬
Comment 4 Wenson Hsieh 2021-03-15 14:24:38 PDT 
Created attachment 423239 [details]
For EWS
Comment 5 EWS 2021-03-15 18:25:47 PDT 
Committed r274457: <https://commits.webkit.org/r274457>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423239 [details].