Bug 223124 – Fix interpolation of orphans and widows CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Fix interpolation of orphans and widows CSS properties

[Antoine Quint]

Created attachment 423054 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Darin Adler]

Comment on attachment 423054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423054&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:642
> +class PositivePropertyWrapper : public PropertyWrapper<T> {

final

> Source/WebCore/animation/CSSPropertyAnimation.cpp:645
> +    PositivePropertyWrapper(CSSPropertyID prop, T (RenderStyle::*getter)() const, void (RenderStyle::*setter)(T))

Please use words, not abbreviations. "property" instead of "prop"

> Source/WebCore/animation/CSSPropertyAnimation.cpp:650
> +    void blend(const CSSPropertyBlendingClient* anim, RenderStyle* dst, const RenderStyle* from, const RenderStyle* to, double progress) const override

"animator" or "animation" or "client", instead of "anim"

"destination" instead of "dst"

final instead of override

I suggest making this private.

[Antoine Quint]

(In reply to Darin Adler from comment #3)
> Comment on attachment 423054 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423054&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:642
> > +class PositivePropertyWrapper : public PropertyWrapper<T> {
> 
> final
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:645
> > +    PositivePropertyWrapper(CSSPropertyID prop, T (RenderStyle::*getter)() const, void (RenderStyle::*setter)(T))
> 
> Please use words, not abbreviations. "property" instead of "prop"
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:650
> > +    void blend(const CSSPropertyBlendingClient* anim, RenderStyle* dst, const RenderStyle* from, const RenderStyle* to, double progress) const override
> 
> "animator" or "animation" or "client", instead of "anim"
> 
> "destination" instead of "dst"
> 
> final instead of override
> 
> I suggest making this private.

This is what happens when you lazily copy/paste code. I'll address those comments and follow up with another patch for bug 223148 which will fix similar issues throughout CSSPropertyAnimation.cpp.

[Antoine Quint]

Committed r274383 (235250@main): <https://commits.webkit.org/235250@main>

[Radar WebKit Bug Importer]

<rdar://problem/75392353>