Bug 223090 - Web Inspector: `WI.Object.singleFireEventListener` should not keep a strong reference to `thisObject`
Summary: Web Inspector: `WI.Object.singleFireEventListener` should not keep a strong r...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-11 14:05 PST by Devin Rousso
Modified: 2021-03-11 15:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.67 KB, patch)
2021-03-11 14:13 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-11 14:05:03 PST
.
Comment 1 Devin Rousso 2021-03-11 14:13:07 PST
Created attachment 422965 [details]
Patch
Comment 2 BJ Burg 2021-03-11 14:26:33 PST
Comment on attachment 422965 [details]
Patch

r=me

Is this testable?
Comment 3 Devin Rousso 2021-03-11 14:49:19 PST
Comment on attachment 422965 [details]
Patch

(In reply to BJ Burg from comment #2) 
> Is this testable?
not in any reliable way that I know of (especially given conservative GC) :/
Comment 4 EWS 2021-03-11 15:11:25 PST
Committed r274303: <https://commits.webkit.org/r274303>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422965 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-11 15:12:16 PST
<rdar://problem/75335202>