Bug 222740 - Web Inspector: Audits Tab: nothing happens when clicking "Start" button in the content area placeholder text
Summary: Web Inspector: Audits Tab: nothing happens when clicking "Start" button in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-04 08:29 PST by Razvan Caliman
Modified: 2021-03-04 10:19 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2021-03-04 08:34 PST, Razvan Caliman 		no flags Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2021-03-04 09:25 PST, Razvan Caliman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Razvan Caliman 2021-03-04 08:29:04 PST 
rdar://75008042

Regressed by: https://bugs.webkit.org/show_bug.cgi?id=196956
Comment 1 Razvan Caliman 2021-03-04 08:34:03 PST 
Created attachment 422233 [details]
Patch
Comment 2 Devin Rousso 2021-03-04 09:00:47 PST 
Comment on attachment 422233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422233&action=review

> Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:347
> +            startNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, (event) => {

Rather than turn this into an arrow function that will capture `this` (which will keep it alive), I think we should replace the `startNavigationItem` 3rd argument with `this` instead so that the `thisObject` that the function is invoked with will be `this` instead of `startNavigationItem`.
Comment 3 Razvan Caliman 2021-03-04 09:15:15 PST 
<rdar://75008042>
Comment 4 Razvan Caliman 2021-03-04 09:25:33 PST 
Created attachment 422238 [details]
Patch
Comment 5 Devin Rousso 2021-03-04 09:41:47 PST 
Comment on attachment 422238 [details]
Patch

r=me
Comment 6 EWS 2021-03-04 10:19:20 PST 
Committed r273900: <https://commits.webkit.org/r273900>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422238 [details].