RESOLVED FIXED 222740
Web Inspector: Audits Tab: nothing happens when clicking "Start" button in the content area placeholder text 
https://bugs.webkit.org/show_bug.cgi?id=222740
Summary Web Inspector: Audits Tab: nothing happens when clicking "Start" button in th...
Razvan Caliman
Reported 2021-03-04 08:29:04 PST
rdar://75008042 Regressed by: https://bugs.webkit.org/show_bug.cgi?id=196956
Attachments
Patch (1.82 KB, patch)
2021-03-04 08:34 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2021-03-04 09:25 PST, Razvan Caliman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Razvan Caliman
Comment 1 2021-03-04 08:34:03 PST
Created attachment 422233 [details] Patch
Devin Rousso
Comment 2 2021-03-04 09:00:47 PST
Comment on attachment 422233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422233&action=review > Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:347 > + startNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, (event) => { Rather than turn this into an arrow function that will capture `this` (which will keep it alive), I think we should replace the `startNavigationItem` 3rd argument with `this` instead so that the `thisObject` that the function is invoked with will be `this` instead of `startNavigationItem`.
Razvan Caliman
Comment 3 2021-03-04 09:15:15 PST
<rdar://75008042>
Razvan Caliman
Comment 4 2021-03-04 09:25:33 PST
Created attachment 422238 [details] Patch
Devin Rousso
Comment 5 2021-03-04 09:41:47 PST
Comment on attachment 422238 [details] Patch r=me
EWS
Comment 6 2021-03-04 10:19:20 PST
Committed r273900: <https://commits.webkit.org/r273900> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422238 [details].
Note You need to log in before you can comment on or make changes to this bug.