RESOLVED FIXED222577
Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedToLaunch() 
https://bugs.webkit.org/show_bug.cgi?id=222577
Summary Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedTo...
Chris Dumez
Reported 2021-03-01 14:51:17 PST
Have WebProcessProxy::requestTermination() call processDidTerminateOrFailedToLaunch() instead of duplicating the code. It was error-prone to have 2 separate code paths whether the process exited due to a crash or a termination request. It led to Bug 222574 for example because we added some logic to remove the process from the cache in processDidTerminateOrFailedToLaunch() but had failed to do so in requestTermination().
Attachments
Patch (6.05 KB, patch)
2021-03-01 14:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-03-01 14:54:18 PST
Created attachment 421870 [details] Patch
Geoffrey Garen
Comment 2 2021-03-01 16:27:54 PST
Comment on attachment 421870 [details] Patch r=me
EWS
Comment 3 2021-03-01 17:45:00 PST
Committed r273713: <https://commits.webkit.org/r273713> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421870 [details].
Radar WebKit Bug Importer
Comment 4 2021-03-01 17:45:24 PST
<rdar://problem/74901873>
Note You need to log in before you can comment on or make changes to this bug.