Bug 222287 - [ews] Commit queue should show commit identifier every time it updates local checkout
Summary: [ews] Commit queue should show commit identifier every time it updates local ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-22 14:00 PST by Aakash Jain
Modified: 2021-02-26 12:32 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2021-02-26 10:12 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-02-22 14:00:36 PST
Commit queue should show commit identifier every time it updates local checkout. Currently it doesn't show the identifier after the second update (e.g.: in step #17 of https://ews-build.webkit.org/#/builders/28/builds/9207).
Comment 1 Aakash Jain 2021-02-26 10:12:59 PST
Created attachment 421670 [details]
Patch
Comment 2 Jonathan Bedard 2021-02-26 10:28:08 PST
Comment on attachment 421670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421670&action=review

> Tools/CISupport/ews-build/factories.py:278
>          self.addStep(CheckOutSource())

I think we want to 'fetch' before ShowIdentifier
Comment 3 Aakash Jain 2021-02-26 11:41:44 PST
(In reply to Jonathan Bedard from comment #2)
> I think we want to 'fetch' before ShowIdentifier
Fetch is already done once in the same build. This is for the case when in same build, commit-queue updates checkout a second time (e.g.: step 18 in https://ews-build.webkit.org/#/builders/28/builds/9351)
Comment 4 Jonathan Bedard 2021-02-26 12:03:45 PST
(In reply to Aakash Jain from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > I think we want to 'fetch' before ShowIdentifier
> Fetch is already done once in the same build. This is for the case when in
> same build, commit-queue updates checkout a second time (e.g.: step 18 in
> https://ews-build.webkit.org/#/builders/28/builds/9351)

Looking closer, we should be fine, but not because we ran fetch earlier, because we're updating the checkout in general instead of updating to a specific revision.
Comment 5 EWS 2021-02-26 12:31:08 PST
Committed r273581: <https://commits.webkit.org/r273581>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421670 [details].
Comment 6 Radar WebKit Bug Importer 2021-02-26 12:32:14 PST
<rdar://problem/74802160>