Bug 222287 – [ews] Commit queue should show commit identifier every time it updates local checkout

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Commit queue should show commit identifier every time it updates local checkout. Currently it doesn't show the identifier after the second update (e.g.: in step #17 of https://ews-build.webkit.org/#/builders/28/builds/9207).

[Aakash Jain]

Created attachment 421670 [details]
Patch

[Jonathan Bedard]

Comment on attachment 421670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421670&action=review

> Tools/CISupport/ews-build/factories.py:278
>          self.addStep(CheckOutSource())

I think we want to 'fetch' before ShowIdentifier

[Aakash Jain]

(In reply to Jonathan Bedard from comment #2)
> I think we want to 'fetch' before ShowIdentifier
Fetch is already done once in the same build. This is for the case when in same build, commit-queue updates checkout a second time (e.g.: step 18 in https://ews-build.webkit.org/#/builders/28/builds/9351)

[Jonathan Bedard]

(In reply to Aakash Jain from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > I think we want to 'fetch' before ShowIdentifier
> Fetch is already done once in the same build. This is for the case when in
> same build, commit-queue updates checkout a second time (e.g.: step 18 in
> https://ews-build.webkit.org/#/builders/28/builds/9351)

Looking closer, we should be fine, but not because we ran fetch earlier, because we're updating the checkout in general instead of updating to a specific revision.

[EWS]

Committed r273581: <https://commits.webkit.org/r273581>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421670 [details].

[Radar WebKit Bug Importer]

<rdar://problem/74802160>