Bug 221966 - [LayoutTests] Convert http/tests/contentdispositionattachmentsandbox convert PHP to Python
Summary: [LayoutTests] Convert http/tests/contentdispositionattachmentsandbox convert ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-16 09:13 PST by Chris Gambrell
Modified: 2021-02-25 10:32 PST (History)
6 users (show)

See Also:

Attachments
Patch (41.50 KB, patch)
2021-02-16 10:10 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (41.51 KB, patch)
2021-02-19 11:26 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-02-16 09:13:19 PST 
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-02-16 09:13:36 PST 
<rdar://problem/74393682>
Comment 2 Chris Gambrell 2021-02-16 10:10:14 PST 
Created attachment 420488 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-16 13:13:55 PST 
Comment on attachment 420488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420488&action=review

> LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.py:16
> +if referrer != '':

'if referrer:' is sufficient
Comment 4 Chris Gambrell 2021-02-19 11:26:34 PST 
Created attachment 420997 [details]
Patch
Comment 5 Chris Gambrell 2021-02-19 11:27:41 PST 
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 420488 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420488&action=review
> 
> > LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.py:16
> > +if referrer != '':
> 
> 'if referrer:' is sufficient

Fixed in comment 4
Comment 6 Jonathan Bedard 2021-02-19 12:54:41 PST 
Comment on attachment 420997 [details]
Patch

Looks good! Let's wait until EWS clears before landing.
Comment 7 EWS 2021-02-25 10:32:36 PST 
Committed r273494: <https://commits.webkit.org/r273494>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420997 [details].