RESOLVED FIXED 221966
[LayoutTests] Convert http/tests/contentdispositionattachmentsandbox convert PHP to Python 
https://bugs.webkit.org/show_bug.cgi?id=221966
Summary [LayoutTests] Convert http/tests/contentdispositionattachmentsandbox convert ...
Chris Gambrell
Reported 2021-02-16 09:13:19 PST
Replacing PHP with equivalent Python CGI scripts
Attachments
Patch (41.50 KB, patch)
2021-02-16 10:10 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Patch (41.51 KB, patch)
2021-02-19 11:26 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-16 09:13:36 PST
<rdar://problem/74393682>
Chris Gambrell
Comment 2 2021-02-16 10:10:14 PST
Created attachment 420488 [details] Patch
Jonathan Bedard
Comment 3 2021-02-16 13:13:55 PST
Comment on attachment 420488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420488&action=review > LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.py:16 > +if referrer != '': 'if referrer:' is sufficient
Chris Gambrell
Comment 4 2021-02-19 11:26:34 PST
Created attachment 420997 [details] Patch
Chris Gambrell
Comment 5 2021-02-19 11:27:41 PST
(In reply to Jonathan Bedard from comment #3) > Comment on attachment 420488 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420488&action=review > > > LayoutTests/http/tests/contentdispositionattachmentsandbox/resources/referer-header-stripped-frame.py:16 > > +if referrer != '': > > 'if referrer:' is sufficient Fixed in comment 4
Jonathan Bedard
Comment 6 2021-02-19 12:54:41 PST
Comment on attachment 420997 [details] Patch Looks good! Let's wait until EWS clears before landing.
EWS
Comment 7 2021-02-25 10:32:36 PST
Committed r273494: <https://commits.webkit.org/r273494> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420997 [details].
Note You need to log in before you can comment on or make changes to this bug.