RESOLVED FIXED 221941
[LayoutTests] Convert http/tests/plugins convert PHP to Python 
https://bugs.webkit.org/show_bug.cgi?id=221941
Summary [LayoutTests] Convert http/tests/plugins convert PHP to Python
Chris Gambrell
Reported 2021-02-15 17:46:45 PST
Replacing PHP with equivalent Python CGI scripts
Attachments
Patch (4.21 KB, patch)
2021-02-15 18:15 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2021-02-16 10:33 PST, Chris Gambrell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-15 17:47:02 PST
<rdar://problem/74373443>
Chris Gambrell
Comment 2 2021-02-15 18:15:51 PST
Created attachment 420409 [details] Patch
Jonathan Bedard
Comment 3 2021-02-16 09:39:58 PST
Comment on attachment 420409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420409&action=review > LayoutTests/http/tests/plugins/resources/redirection-response.py:16 > +if status == 301: Seems like this test could do with some de-duplication. All of the 30*s are basically: sys.stdout.write( 'status: {}\r\n' 'Location: http://{}{}\r\n\r\n'.format(status, host, uri) ) right?
Chris Gambrell
Comment 4 2021-02-16 10:33:19 PST
Created attachment 420495 [details] Patch
Chris Gambrell
Comment 5 2021-02-16 10:33:54 PST
(In reply to Jonathan Bedard from comment #3) > Comment on attachment 420409 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420409&action=review > > > LayoutTests/http/tests/plugins/resources/redirection-response.py:16 > > +if status == 301: > > Seems like this test could do with some de-duplication. All of the 30*s are > basically: > > sys.stdout.write( > 'status: {}\r\n' > 'Location: http://{}{}\r\n\r\n'.format(status, host, uri) > ) > > right? Fixed in comment 4
EWS
Comment 6 2021-02-16 13:43:19 PST
Committed r272924: <https://commits.webkit.org/r272924> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420495 [details].
Note You need to log in before you can comment on or make changes to this bug.