Bug 221941 - [LayoutTests] Convert http/tests/plugins convert PHP to Python
Summary: [LayoutTests] Convert http/tests/plugins convert PHP to Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-02-15 17:46 PST by Chris Gambrell
Modified: 2021-02-16 13:43 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2021-02-15 18:15 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2021-02-16 10:33 PST, Chris Gambrell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-02-15 17:46:45 PST 
Replacing PHP with equivalent Python CGI scripts
Comment 1 Radar WebKit Bug Importer 2021-02-15 17:47:02 PST 
<rdar://problem/74373443>
Comment 2 Chris Gambrell 2021-02-15 18:15:51 PST 
Created attachment 420409 [details]
Patch
Comment 3 Jonathan Bedard 2021-02-16 09:39:58 PST 
Comment on attachment 420409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420409&action=review

> LayoutTests/http/tests/plugins/resources/redirection-response.py:16
> +if status == 301:

Seems like this test could do with some de-duplication. All of the 30*s are basically:

sys.stdout.write(
    'status: {}\r\n'
    'Location: http://{}{}\r\n\r\n'.format(status, host, uri)
)

right?
Comment 4 Chris Gambrell 2021-02-16 10:33:19 PST 
Created attachment 420495 [details]
Patch
Comment 5 Chris Gambrell 2021-02-16 10:33:54 PST 
(In reply to Jonathan Bedard from comment #3)
> Comment on attachment 420409 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420409&action=review
> 
> > LayoutTests/http/tests/plugins/resources/redirection-response.py:16
> > +if status == 301:
> 
> Seems like this test could do with some de-duplication. All of the 30*s are
> basically:
> 
> sys.stdout.write(
>     'status: {}\r\n'
>     'Location: http://{}{}\r\n\r\n'.format(status, host, uri)
> )
> 
> right?

Fixed in comment 4
Comment 6 EWS 2021-02-16 13:43:19 PST 
Committed r272924: <https://commits.webkit.org/r272924>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420495 [details].