Bug 221711 - [Flatpak SDK] Support multiple builds running at the same time
Summary: [Flatpak SDK] Support multiple builds running at the same time
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
Keywords: InRadar
Depends on:
Reported: 2021-02-10 12:42 PST by Lauro Moura
Modified: 2021-02-11 10:54 PST (History)
4 users (show)

See Also:

Patch (3.51 KB, patch)
2021-02-10 20:44 PST, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-02-10 12:42:06 PST
As part of Flatpak 1.10 changes regarding environment variables, the Flatpak SDK currently creates a `WebKitBuild/flatpak-env.json` variable to pass the needed environment variables to the webkit-bwrap wrapper. One such variable is  WEBKIT_BUILD_DIR_BIND_MOUNT, which is used to bindmount the WebKitBuild/<PORT>/<CONFIG> directory into WebKitBuild/<CONFIG> inside the sanbox.

While this has been working quite well when running *single* commands, this approach has some limitations. For example, running in parallel GTK and WPE MiniBrowsers. Each command would generate a different flatpak-env.json with its own config.

Related revisions and bugs:

* Initial flatpak-env.json patch: r271938 / bug220781
* Followup fix avoiding early deletion: r272018 / bug221070
Comment 1 Lauro Moura 2021-02-10 20:44:48 PST
Created attachment 419943 [details]
Comment 2 EWS 2021-02-11 01:29:29 PST
Committed r272712: <https://commits.webkit.org/r272712>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419943 [details].
Comment 3 Radar WebKit Bug Importer 2021-02-11 01:30:19 PST