Bug 220788 - Disable Options:useAtMethod because of compatibility issue.
Summary: Disable Options:useAtMethod because of compatibility issue.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 20:28 PST by Mark Lam
Modified: 2021-01-22 09:27 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (1.84 KB, patch)
2021-01-20 20:35 PST, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (11.57 KB, patch)
2021-01-21 11:52 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
patch for landing. (5.34 KB, patch)
2021-01-21 13:53 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Mark Lam 2021-01-20 20:35:10 PST 
Created attachment 418019 [details]
proposed patch.

Let's test this on the EWS first.
Comment 2 Mark Lam 2021-01-21 11:52:42 PST 
Created attachment 418067 [details]
proposed patch.
Comment 3 Mark Lam 2021-01-21 13:53:10 PST 
Created attachment 418082 [details]
patch for landing.

Yusuke also told me offline that I should enable Options::useAtMethod for the tests instead.  I've reworked the patch to apply that.  Will wait for the EWS before landing.
Comment 4 EWS 2021-01-22 09:27:47 PST 
Committed r271746: <https://trac.webkit.org/changeset/271746>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418082 [details].