Bug 220586 - [buildbot] WebKitGTK(GTK4) isn't triggered after a binary build
Summary: [buildbot] WebKitGTK(GTK4) isn't triggered after a binary build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-13 04:05 PST by Diego Pino
Modified: 2021-01-13 06:58 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2021-01-13 04:07 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2021-01-13 04:34 PST, Diego Pino 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-01-13 04:05:01 PST 
[buildbot] WebKitGTK(GTK4) isn't triggered after a binary build
Comment 1 Diego Pino 2021-01-13 04:07:33 PST 
Created attachment 417521 [details]
Patch
Comment 2 Aakash Jain 2021-01-13 04:19:33 PST 
Comment on attachment 417521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417521&action=review

looks good, just need to change the triggerable name.

> Tools/CISupport/build-webkit-org/config.json:336
> +                                   "gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests", "gtk-linux-64-release-gtk4"],

please append "-tests" at at end of triggerable name to match with other similar names.

> Tools/CISupport/build-webkit-org/config.json:647
> +                    { "type": "Triggerable", "name": "gtk-linux-64-release-gtk4",

ditto.
Comment 3 Diego Pino 2021-01-13 04:34:00 PST 
Created attachment 417525 [details]
Patch
Comment 4 EWS 2021-01-13 05:21:12 PST 
Committed r271438: <https://trac.webkit.org/changeset/271438>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417525 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-13 05:22:15 PST 
<rdar://problem/73147968>
Comment 6 Aakash Jain 2021-01-13 06:58:28 PST 
@bot-watchers, false failure on windows: fast/css/user-drag-none.htm