Bug 220451 - [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge
Summary: [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-07 18:23 PST by Yusuke Suzuki
Modified: 2021-01-08 08:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2021-01-07 18:33 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-07 18:23:31 PST 
[JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge
Comment 1 Yusuke Suzuki 2021-01-07 18:33:43 PST 
Created attachment 417235 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-07 18:34:01 PST 
<rdar://problem/71237065>
Comment 3 Mark Lam 2021-01-07 19:07:25 PST 
Comment on attachment 417235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review

r=me with ChangeLog fix.

> Source/JavaScriptCore/ChangeLog:11
> +        and if it is, we should make it generic one instead of using fast TypedArray path.

I think you meant to say "if it is not" instead here.
Comment 4 Yusuke Suzuki 2021-01-07 19:08:02 PST 
Comment on attachment 417235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review

>> Source/JavaScriptCore/ChangeLog:11
>> +        and if it is, we should make it generic one instead of using fast TypedArray path.
> 
> I think you meant to say "if it is not" instead here.

Thanks! Fixed.
Comment 5 Yusuke Suzuki 2021-01-08 08:30:43 PST 
Committed r271297: <https://trac.webkit.org/changeset/271297>