Bug 220336 - PCM: Experimental debug mode stops working after initial use
Summary: PCM: Experimental debug mode stops working after initial use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-05 13:49 PST by John Wilander
Modified: 2021-01-05 17:09 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.28 KB, patch)
2021-01-05 13:53 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-01-05 13:49:28 PST 
We need to make sure the PCM debug mode flag sticks.
Comment 1 John Wilander 2021-01-05 13:49:40 PST 
<rdar://problem/72398086>
Comment 2 John Wilander 2021-01-05 13:53:58 PST 
Created attachment 417035 [details]
Patch
Comment 3 Brent Fulgham 2021-01-05 14:30:13 PST 
Comment on attachment 417035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417035&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327
> +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled)

Is this always called on NetworkProcess initialization? And I assume toggling the setting switch in UIProcess sends a message that hits this?
Comment 4 John Wilander 2021-01-05 15:07:21 PST 
Comment on attachment 417035 [details]
Patch

Thanks, Brent!
Comment 5 John Wilander 2021-01-05 15:08:25 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 417035 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417035&action=review
> 
> r=me
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327
> > +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled)
> 
> Is this always called on NetworkProcess initialization? And I assume
> toggling the setting switch in UIProcess sends a message that hits this?

I don't know actually. I think this may be a feature switch that requires a browser restart.
Comment 6 EWS 2021-01-05 17:09:18 PST 
Committed r271184: <https://trac.webkit.org/changeset/271184>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417035 [details].