Bug 220248 - [LFC Display] Add a Display::Box flag for HasTransfrom
Summary: [LFC Display] Add a Display::Box flag for HasTransfrom
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-04 10:19 PST by Simon Fraser (smfr)
Modified: 2021-01-11 10:20 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.22 KB, patch)
2021-01-04 10:20 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-01-04 10:19:59 PST 
[LFC Display] Add a Display::Box flag for HasTransfrom
Comment 1 Simon Fraser (smfr) 2021-01-04 10:20:21 PST 
Created attachment 416953 [details]
Patch
Comment 2 Sam Weinig 2021-01-04 13:44:25 PST 
Comment on attachment 416953 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416953&action=review

> Source/WebCore/ChangeLog:10
> +        It's possible for a non-box model box to have a RenderStyle with a transform, but that
> +        style isn't applied because transforms only apply to atomic inline or block boxes,
> +        so store a bit on Box for boxes that have transforms.

This seems like really useful information to include as a comment in the header explaining why the state is seemingly potentially duplicated.
Comment 3 Radar WebKit Bug Importer 2021-01-11 10:20:16 PST 
<rdar://problem/73003363>