Bug 22018 - enable-developer-extras doesn't toggle WebInspector
Summary: enable-developer-extras doesn't toggle WebInspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Christian Dywan
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-10-31 15:06 PDT by Christian Dywan
Modified: 2008-10-31 17:28 PDT (History)
0 users

See Also:

Attachments
Add if branch for enable-developer-extras (826 bytes, patch)
2008-10-31 15:07 PDT, Christian Dywan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2008-10-31 15:06:22 PDT 
While adding a preference for enable-developer-extras I noticed that it didn't affect existing web views.

Basically there's a notify 'else if' missing.
Comment 1 Christian Dywan 2008-10-31 15:07:38 PDT 
Created attachment 24819 [details]
Add if branch for enable-developer-extras
Comment 2 Mark Rowe (bdash) 2008-10-31 15:41:55 PDT 
Comment on attachment 24819 [details]
Add if branch for enable-developer-extras

r=me
Comment 3 Christian Dywan 2008-10-31 17:28:32 PDT 
Comment on attachment 24819 [details]
Add if branch for enable-developer-extras

2008-10-31  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=22018
        enable-developer-extras doesn't toggle WebInspector

        * webkit/webkitwebview.cpp:
        Add missing 'if' in notification for 'enable-developer-extras'.