Bug 220124 - Use sendWithAsyncReply instead of ValidateCommandCallback
Summary: Use sendWithAsyncReply instead of ValidateCommandCallback
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2020-12-23 10:55 PST by Alex Christensen
Modified: 2021-01-05 10:45 PST (History)
6 users (show)

See Also:

Patch (13.45 KB, patch)
2020-12-23 10:55 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (14.29 KB, patch)
2021-01-05 09:54 PST, Alex Christensen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-12-23 10:55:14 PST
Use sendWithAsyncReply instead of ValidateCommandCallback
Comment 1 Alex Christensen 2020-12-23 10:55:53 PST
Created attachment 416717 [details]
Comment 2 Radar WebKit Bug Importer 2020-12-30 10:56:13 PST
Comment 3 Chris Dumez 2021-01-05 08:41:54 PST
Comment on attachment 416717 [details]

r=me but please fix GTK build.
Comment 4 Alex Christensen 2021-01-05 09:54:12 PST
Created attachment 417014 [details]
Comment 5 EWS Watchlist 2021-01-05 09:55:04 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 EWS 2021-01-05 10:24:42 PST
Tools/Scripts/svn-apply failed to apply attachment 417014 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 7 Alex Christensen 2021-01-05 10:45:04 PST