Bug 219834 - Move createAppHighlightRangeData into AppHighlightStorage source file
Summary: Move createAppHighlightRangeData into AppHighlightStorage source file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-13 08:39 PST by Don Olmstead
Modified: 2020-12-13 09:56 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2020-12-13 08:54 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-12-13 08:39:25 PST
The createAppHighlightRangeData function was defined statically within AppHighlightListData.cpp but used in AppHighlightStorage.cpp. This breaks non-unified builds.
Comment 1 Don Olmstead 2020-12-13 08:54:50 PST
Created attachment 416118 [details]
Patch
Comment 2 Devin Rousso 2020-12-13 09:47:38 PST
Comment on attachment 416118 [details]
Patch

rs=me
Comment 3 EWS 2020-12-13 09:55:34 PST
Committed r270750: <https://trac.webkit.org/changeset/270750>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416118 [details].
Comment 4 Radar WebKit Bug Importer 2020-12-13 09:56:20 PST
<rdar://problem/72271062>