Bug 219649 - [iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout correctly upon exit
Summary: [iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-08 12:17 PST by Jer Noble
Modified: 2021-01-13 16:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2020-12-08 12:19 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2020-12-08 13:51 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2020-12-08 15:23 PST, Jer Noble 		dbates: review+
Details | Formatted Diff | Diff
Patch for landing (4.39 KB, patch)
2021-01-13 16:22 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-12-08 12:17:29 PST 
[iOS] Entering fullscreen from less-than-fullscreen WKWebView does not layout correctly upon exit
Comment 1 Jer Noble 2020-12-08 12:17:56 PST 
<rdar://problem/72053237>
Comment 2 Jer Noble 2020-12-08 12:19:46 PST 
Created attachment 415662 [details]
Patch
Comment 3 Jer Noble 2020-12-08 13:51:55 PST 
Created attachment 415674 [details]
Patch
Comment 4 Tim Horton 2020-12-08 15:09:02 PST 
Comment on attachment 415674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415674&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:245
> +#if PLATFORM(IOS)

It seems unlikely that you mean PLATFORM(IOS) here? Shouldn't this be all IOS_FAMILY?

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:115
> +    BOOL _savedHasOverridenLayoutParameters;
> +    CGSize _savedMinimumLayoutSizeOverride;
> +    CGSize _savedMaximumUnobscuredSizeOverride;

Slightly disconcerting that all the rest are initialized.
Comment 5 Jer Noble 2020-12-08 15:23:36 PST 
Created attachment 415683 [details]
Patch
Comment 6 Jer Noble 2020-12-08 15:24:09 PST 
(In reply to Tim Horton from comment #4)
> Comment on attachment 415674 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415674&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:245
> > +#if PLATFORM(IOS)
> 
> It seems unlikely that you mean PLATFORM(IOS) here? Shouldn't this be all
> IOS_FAMILY?

Ugh. Yes, IOS_FAMILY>

> > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:115
> > +    BOOL _savedHasOverridenLayoutParameters;
> > +    CGSize _savedMinimumLayoutSizeOverride;
> > +    CGSize _savedMaximumUnobscuredSizeOverride;
> 
> Slightly disconcerting that all the rest are initialized.

Added initializers.
Comment 7 Daniel Bates 2020-12-21 22:58:19 PST 
Comment on attachment 415683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415683&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:246
> +@property (nonatomic, readonly) BOOL _hasOverridenLayoutParameters;

Ok as is. Consider overriding instead of overridden. If going to keep overridden then consider fixing spelling.

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:159
> +            _savedMinimumLayoutSizeOverride = webView._minimumLayoutSizeOverride;

Ok as is. Consider rename using overriding
Comment 8 Jer Noble 2021-01-13 16:22:45 PST 
Created attachment 417578 [details]
Patch for landing