Bug 219063 - GPU-process-hosted RemoteLayerBackingStore should flush off the main thread
Summary: GPU-process-hosted RemoteLayerBackingStore should flush off the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-17 19:02 PST by Tim Horton
Modified: 2020-11-17 22:17 PST (History)
5 users (show)

See Also:

Attachments
Patch (20.54 KB, patch)
2020-11-17 19:02 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (18.52 KB, patch)
2020-11-17 20:10 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-11-17 19:02:02 PST 
GPU-process-hosted RemoteLayerBackingStore should flush off the main thread
Comment 1 Tim Horton 2020-11-17 19:02:15 PST 
Created attachment 414400 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-11-17 19:34:08 PST 
Comment on attachment 414400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414400&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:370
> +    void flush() override

final?
Comment 3 Tim Horton 2020-11-17 19:38:47 PST 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 414400 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414400&action=review
> 
> > Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:370
> > +    void flush() override
> 
> final?

Oh! I forgot somebody (Sam?) said that on another patch.
Comment 4 Tim Horton 2020-11-17 20:10:39 PST 
Created attachment 414402 [details]
Patch
Comment 5 EWS 2020-11-17 22:16:08 PST 
Committed r269943: <https://trac.webkit.org/changeset/269943>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414402 [details].
Comment 6 Radar WebKit Bug Importer 2020-11-17 22:17:19 PST 
<rdar://problem/71524141>