Bug 218700 - Web Inspector: Timelines: switching between Events/Frames while editing instruments leaves the UI in a broken state
Summary: Web Inspector: Timelines: switching between Events/Frames while editing instr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-09 00:05 PST by Devin Rousso
Modified: 2022-05-27 16:53 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-11-09 00:05:19 PST 
# STEPS TO REPRODUCE
1. inspect any page
2. go to the Timelines Tab
3. go to the Events view
4. click the Edit button

# EXPECTED
the Events and Frames buttons should be disabled

# ACTUAL
Can click the Events and Frames buttons (note that this only changes the hierarchical path navigation items, not the content itself).  Clicking Done when in the Frames view will also incorrectly show the enabled instruments as would be shown in the Events view.
Comment 1 Radar WebKit Bug Importer 2020-11-09 00:05:40 PST 
<rdar://problem/71180148>
Comment 2 Devin Rousso 2022-05-27 13:21:37 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1117
Comment 3 EWS 2022-05-27 16:53:28 PDT 
Committed r294967 (251071@main): <https://commits.webkit.org/251071@main>

Reviewed commits have been landed. Closing PR #1117 and removing active labels.