Bug 218082 - [webkitpy] Rename slave to worker in perftestsrunner
Summary: [webkitpy] Rename slave to worker in perftestsrunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency treegraph
 
Reported: 2020-10-22 08:55 PDT by Aakash Jain
Modified: 2021-05-17 10:01 PDT (History)
7 users (show)

See Also:


Attachments
Patch (11.54 KB, patch)
2020-10-22 09:28 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch for landing (11.48 KB, patch)
2020-10-22 11:00 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-22 08:55:09 PDT
Rename slave to worker in perftestsrunner. This is to use more inclusive naming.
Comment 1 Aakash Jain 2020-10-22 09:28:31 PDT
Created attachment 412109 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-10-22 09:31:37 PDT
<rdar://problem/70576780>
Comment 3 Ryosuke Niwa 2020-10-22 10:52:52 PDT
Comment on attachment 412109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412109&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:178
> +        # TODO: remove this test and the corresponding parameter after all instances of this deprecated parameter have been removed

Use FIXME instead.
Comment 4 Aakash Jain 2020-10-22 11:00:27 PDT
Created attachment 412115 [details]
Patch for landing
Comment 5 EWS 2020-10-22 11:51:14 PDT
Committed r268880: <https://trac.webkit.org/changeset/268880>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412115 [details].