RESOLVED FIXED 217957
TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file 
https://bugs.webkit.org/show_bug.cgi?id=217957
Summary TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file
Michael Catanzaro
Reported 2020-10-20 08:13:27 PDT
[5187/5225] Building CXX object Tools/...WebKitTestRunner.dir/TestOptions.cpp.o In file included from ../../Tools/WebKitTestRunner/TestOptions.cpp:29: DerivedSources/WebKitTestRunner/TestOptionsGeneratedKeys.h:30:52: warning: backslash-newline at end of file 30 | #define GENERATED_WEB_PREFERENCE_KEY_TYPE_MAPPINGS \ | I guess this is bad because something else from another header could be on the next line, depending on the order that headers get included into the source file.
Attachments
Patch (1.50 KB, patch)
2020-10-20 08:15 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-10-20 08:15:19 PDT
Created attachment 411866 [details] Patch
Sam Weinig
Comment 2 2020-10-20 09:24:55 PDT
Thanks.
EWS
Comment 3 2020-10-20 10:06:02 PDT
Committed r268740: <https://trac.webkit.org/changeset/268740> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411866 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-20 10:07:35 PDT
<rdar://problem/70489878>
Note You need to log in before you can comment on or make changes to this bug.