RESOLVED FIXED 217907
Switch to a static pattern for DumpRenderTree preferences generation to avoid ambiguous rules 
https://bugs.webkit.org/show_bug.cgi?id=217907
Summary Switch to a static pattern for DumpRenderTree preferences generation to avoid...
Sam Weinig
Reported 2020-10-19 09:37:26 PDT
Switch to a static pattern for DumpRenderTree preferences generation to mavoid ambiguous rules
Attachments
Patch (4.36 KB, patch)
2020-10-19 09:39 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (4.36 KB, patch)
2020-10-19 10:03 PDT, Sam Weinig 		simon.fraser: review+
sam: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-19 09:39:22 PDT
Created attachment 411753 [details] Patch
Darin Adler
Comment 2 2020-10-19 09:40:21 PDT
mavoid
Sam Weinig
Comment 3 2020-10-19 10:03:39 PDT
Created attachment 411757 [details] Patch
Darin Adler
Comment 4 2020-10-19 11:11:27 PDT
Comment on attachment 411757 [details] Patch Lets do more of this in the WebCore DerivedSources.make too?
Sam Weinig
Comment 5 2020-10-19 11:13:10 PDT
(In reply to Darin Adler from comment #4) > Comment on attachment 411757 [details] > Patch > > Lets do more of this in the WebCore DerivedSources.make too? Yeah, if it works out here, I will do it for the rest as well.
Sam Weinig
Comment 6 2020-10-19 12:40:38 PDT
Committed r268682: <https://trac.webkit.org/changeset/268682>
Radar WebKit Bug Importer
Comment 7 2020-10-19 12:41:20 PDT
<rdar://problem/70451920>
Ryan Haddad
Comment 8 2020-10-19 15:08:13 PDT
Reverted r268495, r268571, and r268682 for reason: Caused failures for some internal build configurations Committed r268693: <https://trac.webkit.org/changeset/268693>
Ryan Haddad
Comment 9 2020-10-19 18:56:51 PDT
Re-landing these changes as the underlying issue may have been with CI infrastructure (and should now be resolved) Committed r268705: <https://trac.webkit.org/changeset/268705> Collapse All Comments Expand All Comments Add Comment
Note You need to log in before you can comment on or make changes to this bug.