Bug 217825 – [JHBuild] Update libwpe and wpebackend-fdo and add libmanette to minimal moduleset

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

libmanette 0.2.4 is required for enabling gamepad support, which defaults to on since r268389 for developer builds

the version shipped by ubuntu-20.04 is not enough (0.2.3), so we should include this on the minimal moduleset which is used to generate the bundle products on the packaging bots.
See: https://build.webkit.org/builders/GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004

meanwhile at this, seize to also update the libwpe and wpebackend-fdo libraries

[Carlos Alberto Lopez Perez]

Created attachment 411573 [details]
Patch

[Adrian Perez]

Comment on attachment 411573 [details]
Patch

Whoops, I completely forgot about the JHBuild moduleset when doing the bit
to enable the gamepad support for development builds. Thanks for this!

View in context: https://bugs.webkit.org/attachment.cgi?id=411573&action=review

> Tools/jhbuild/jhbuild-minimal.modules:102
> +  <!-- libmanette >= 0.2.4 required for GamePad support -->

Any reason to not use libmanette 0.2.5?

[Carlos Alberto Lopez Perez]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 411573 [details]
> Patch
> 
> Whoops, I completely forgot about the JHBuild moduleset when doing the bit
> to enable the gamepad support for development builds. Thanks for this!
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411573&action=review
> 
> > Tools/jhbuild/jhbuild-minimal.modules:102
> > +  <!-- libmanette >= 0.2.4 required for GamePad support -->
> 
> Any reason to not use libmanette 0.2.5?

Yes. The purpose of the minimal moduleset is to only build the libraries if the system one is not new enough. That is why the libraries listed there include a <pkg-config> entry. That tells jhbuild to first search for that library on the system and if the version shipped by the system is equal or newer than the version listed on the module, then it skips building that library. This way is possible to only build the library if is really needed.

If i list a version newer than the minimum required then the above trick won't work and it may end building the library when the one shipped by the system was enough.

This minimal moduleset is just used for the packaging bots and for using it you have to export an environment variable WEBKIT_JHBUILD_MODULESET=minimal
See bug 213614

[Carlos Alberto Lopez Perez]

Comment on attachment 411573 [details]
Patch

Clearing flags on attachment: 411573

Committed r268591: <https://trac.webkit.org/changeset/268591>

[Carlos Alberto Lopez Perez]

All reviewed patches have been landed.  Closing bug.