Bug 217799 - [Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with icecc and toolchains aren't generated yet
Summary: [Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with i...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
Keywords: InRadar
Depends on:
Reported: 2020-10-15 18:08 PDT by Fujii Hironori
Modified: 2020-10-17 01:17 PDT (History)
2 users (show)

See Also:

Patch (1.74 KB, patch)
2020-10-16 01:32 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-10-15 18:08:12 PDT
[Flatpak SDK] flatpakutils.py reports "KeyError: 'gcc'" error if using with icecc and toolchains aren't generated yet

I'm using icecc.

$ env | grep -i icecc
ICECC_SCHEDULER={my scheduler ip addr}

build-webkit reports the following unfriendly error message:

$ ./Tools/Scripts/build-webkit --gtk --release
Building flatpak based environment
Traceback (most recent call last):
  File "/home/fujii/webkit/gb/Tools/Scripts/webkit-flatpak", line 28, in <module>
  File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 897, in run
    return self.main()
  File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 886, in main
    result = self.setup_dev_env()
  File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 978, in setup_dev_env
    return self.run_in_sandbox(*self.user_command)
  File "/home/fujii/webkit/gb/Tools/flatpak/flatpakutils.py", line 822, in run_in_sandbox
    toolchain_path = self.icc_version[toolchain_name]
KeyError: 'gcc'

WebKitBuild/UserFlatpak/webkit_flatpak_config.json is not generated.
Manually invoking Tools/Scripts/webkit-flatpak --regenerate-toolchains solves the issue.
Comment 1 Philippe Normand 2020-10-16 01:32:59 PDT
Created attachment 411546 [details]
Comment 2 Fujii Hironori 2020-10-16 13:38:45 PDT
Comment on attachment 411546 [details]

Thank you.
Comment 3 EWS 2020-10-17 01:16:17 PDT
Committed r268639: <https://trac.webkit.org/changeset/268639>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411546 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-17 01:17:20 PDT