RESOLVED FIXED 217589
GeneratePreferences.rb is noisy 
https://bugs.webkit.org/show_bug.cgi?id=217589
Summary GeneratePreferences.rb is noisy
Michael Catanzaro
Reported 2020-10-11 15:31:45 PDT
Scripts that run during the build should be quiet. Shhh! We have a history of trying to keep it quiet going back at least to bug #163868. So let's not print this: [1713/2435] Generating ../../DerivedSources/WebKit/WebPag.../DerivedSources/WebKit/WebPreferencesStoreDefaultsMap.cpp Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesKeys.cpp.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesKeys.h.erb Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb
Attachments
Patch (1.30 KB, patch)
2020-10-11 15:34 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2020-10-11 15:34:24 PDT
Created attachment 411071 [details] Patch
EWS
Comment 2 2020-10-11 18:39:03 PDT
Committed r268334: <https://trac.webkit.org/changeset/268334> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411071 [details].
Radar WebKit Bug Importer
Comment 3 2020-10-11 18:40:16 PDT
<rdar://problem/70189604>
Note You need to log in before you can comment on or make changes to this bug.