Bug 217589 - GeneratePreferences.rb is noisy
Summary: GeneratePreferences.rb is noisy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-11 15:31 PDT by Michael Catanzaro
Modified: 2020-10-11 18:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2020-10-11 15:34 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2020-10-11 15:31:45 PDT 
Scripts that run during the build should be quiet. Shhh! We have a history of trying to keep it quiet going back at least to bug #163868. So let's not print this:

[1713/2435] Generating ../../DerivedSources/WebKit/WebPag.../DerivedSources/WebKit/WebPreferencesStoreDefaultsMap.cpp
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesKeys.cpp.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesKeys.h.erb
Generating output for template file: /home/mcatanzaro/Projects/WebKit/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb
Comment 1 Michael Catanzaro 2020-10-11 15:34:24 PDT 
Created attachment 411071 [details]
Patch
Comment 2 EWS 2020-10-11 18:39:03 PDT 
Committed r268334: <https://trac.webkit.org/changeset/268334>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411071 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-11 18:40:16 PDT 
<rdar://problem/70189604>