Bug 217507 - [WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174
Summary: [WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped sinc...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
Keywords: InRadar
Depends on:
Reported: 2020-10-09 00:29 PDT by Fujii Hironori
Modified: 2020-10-09 12:52 PDT (History)
9 users (show)

See Also:

Patch (3.71 KB, patch)
2020-10-09 00:43 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-10-09 00:29:28 PDT
[WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174

For example, compositing/images/content-image.html shows no image.

Some images aren't shown in http://www.satine.org/research/webkit/snowleopard/snowstack.html
Comment 1 Fujii Hironori 2020-10-09 00:30:51 PDT
since r260174
Bug 210544 – TextureMapper renders video element with "object-fit: cover" incorrectly
Comment 2 Fujii Hironori 2020-10-09 00:43:33 PDT
Created attachment 410921 [details]
Comment 3 Tomoki Imai 2020-10-09 02:08:52 PDT
(In reply to Fujii Hironori from comment #2)
> Created attachment 410921 [details]
> Patch

Thanks Fujii -san for the patch, and sorry for making a regression in WinCairo.
The change looks good to me, but I'd like to ask Ross, Don to review and r+ in case.
Comment 4 Fujii Hironori 2020-10-09 12:51:25 PDT
Comment on attachment 410921 [details]

Clearing flags on attachment: 410921

Committed r268280: <https://trac.webkit.org/changeset/268280>
Comment 5 Fujii Hironori 2020-10-09 12:51:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-10-09 12:52:18 PDT