Bug 217366 - Align URL setters with reasonably behaving other browsers
Summary: Align URL setters with reasonably behaving other browsers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-05 22:39 PDT by Alex Christensen
Modified: 2020-10-06 08:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (18.35 KB, patch)
2020-10-05 22:42 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (22.27 KB, patch)
2020-10-06 08:02 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-10-05 22:39:58 PDT
Align URL setters with reasonably behaving other browsers
Comment 1 Alex Christensen 2020-10-05 22:42:58 PDT
Created attachment 410615 [details]
Patch
Comment 2 youenn fablet 2020-10-06 00:50:32 PDT
Comment on attachment 410615 [details]
Patch

LGTM.
Please update the two failing tests to match the new behavior.

View in context: https://bugs.webkit.org/attachment.cgi?id=410615&action=review

> Source/WTF/ChangeLog:10
> +        I think these behaviors make sense, and aligning with these behaviors makes it so there are no tests in url-setters.html

Do we have some spec language describing that? If not, can we file an issue?
Comment 3 Alex Christensen 2020-10-06 08:00:18 PDT
Comment on attachment 410615 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410615&action=review

>> Source/WTF/ChangeLog:10
>> +        I think these behaviors make sense, and aligning with these behaviors makes it so there are no tests in url-setters.html
> 
> Do we have some spec language describing that? If not, can we file an issue?

https://github.com/whatwg/url/issues/551
Comment 4 Alex Christensen 2020-10-06 08:02:08 PDT
Created attachment 410635 [details]
Patch
Comment 5 EWS 2020-10-06 08:45:38 PDT
Committed r268050: <https://trac.webkit.org/changeset/268050>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410635 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-06 08:46:20 PDT
<rdar://problem/70001020>