RESOLVED FIXED217366
Align URL setters with reasonably behaving other browsers 
https://bugs.webkit.org/show_bug.cgi?id=217366
Summary Align URL setters with reasonably behaving other browsers
Alex Christensen
Reported 2020-10-05 22:39:58 PDT
Align URL setters with reasonably behaving other browsers
Attachments
Patch (18.35 KB, patch)
2020-10-05 22:42 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.27 KB, patch)
2020-10-06 08:02 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-10-05 22:42:58 PDT
Created attachment 410615 [details] Patch
youenn fablet
Comment 2 2020-10-06 00:50:32 PDT
Comment on attachment 410615 [details] Patch LGTM. Please update the two failing tests to match the new behavior. View in context: https://bugs.webkit.org/attachment.cgi?id=410615&action=review > Source/WTF/ChangeLog:10 > + I think these behaviors make sense, and aligning with these behaviors makes it so there are no tests in url-setters.html Do we have some spec language describing that? If not, can we file an issue?
Alex Christensen
Comment 3 2020-10-06 08:00:18 PDT
Comment on attachment 410615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410615&action=review >> Source/WTF/ChangeLog:10 >> + I think these behaviors make sense, and aligning with these behaviors makes it so there are no tests in url-setters.html > > Do we have some spec language describing that? If not, can we file an issue? https://github.com/whatwg/url/issues/551
Alex Christensen
Comment 4 2020-10-06 08:02:08 PDT
Created attachment 410635 [details] Patch
EWS
Comment 5 2020-10-06 08:45:38 PDT
Committed r268050: <https://trac.webkit.org/changeset/268050> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410635 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-06 08:46:20 PDT
<rdar://problem/70001020>
Note You need to log in before you can comment on or make changes to this bug.