RESOLVED FIXED 217328
Use memset to zero vectors in PeriodicWave::createBandLimitedTables() 
https://bugs.webkit.org/show_bug.cgi?id=217328
Summary Use memset to zero vectors in PeriodicWave::createBandLimitedTables()
Chris Dumez
Reported 2020-10-05 12:54:12 PDT
Use memset to zero vectors in PeriodicWave::createBandLimitedTables() instead of a for loop.
Attachments
Patch (2.33 KB, patch)
2020-10-05 12:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-05 12:55:58 PDT
Created attachment 410540 [details] Patch
Darin Adler
Comment 2 2020-10-05 14:03:49 PDT
Comment on attachment 410540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410540&action=review > Source/WebCore/ChangeLog:9 > + Use memset to zero vectors in PeriodicWave::createBandLimitedTables() instead of a for > + loop, for performance reasons. On reflection, I’m surprised this improves performance. I would expect a modern compiler to convert both into the exact same code.
EWS
Comment 3 2020-10-05 14:29:50 PDT
Committed r268002: <https://trac.webkit.org/changeset/268002> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410540 [details].
Radar WebKit Bug Importer
Comment 4 2020-10-05 14:30:28 PDT
<rdar://problem/69971290>
Note You need to log in before you can comment on or make changes to this bug.