Bug 217261 – [JSC] Introduce JITOperationList to validate JIT-caged pointers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Introduce JITOperationList to validate JIT-caged pointers

[Yusuke Suzuki]

Created attachment 410393 [details]
Patch

[Yusuke Suzuki]

Created attachment 410394 [details]
Patch

[Yusuke Suzuki]

Created attachment 410396 [details]
Patch

[Yusuke Suzuki]

Created attachment 410398 [details]
Patch

[Saam Barati]

Comment on attachment 410398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410398&action=review

r=me

> Source/JavaScriptCore/assembler/JITOperationList.h:50
> +    JS_EXPORT_PRIVATE static void populatePointersInEmbedder1(const uintptr_t* beginHost, const uintptr_t* endHost, const uintptr_t* beginOperations, const uintptr_t* endOperations);
> +    JS_EXPORT_PRIVATE static void populatePointersInEmbedder2(const uintptr_t* beginHost, const uintptr_t* endHost, const uintptr_t* beginOperations, const uintptr_t* endOperations);

let's do what we  talked  about on slack of just a  single function

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:380
> +    WebCore::populateJITOperations();

could we have a version of "initialize" per library that calls the necessary initialize functions blow it?

e.g, JSC::initialize,
WebCore::initilziae, that calls JSC::initialize and calls WebCore::populateJITOperations
WebKit::initialize, that calls WebCore::initialize, and WebKit::populateJITOperations

[Yusuke Suzuki]

Created attachment 410404 [details]
Patch

[Yusuke Suzuki]

Created attachment 410405 [details]
Patch

[EWS]

Committed r267938: <https://trac.webkit.org/changeset/267938>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410405 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69921874>

[Yusuke Suzuki]

Committed r268013: <https://trac.webkit.org/changeset/268013>